svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-491781626 > @svenvogel thanks for you explanation. > Currently we use 'Windows PV' for windows vm. All disk are virtio. > We hope this will not be broken. > Change OS type from 'Windows PV' to 'Other PV' will lead to changes not only in cloudstack itself, but also in some maintenance scripts. > > so please change the code to following if possible. > > ``` > if (volume.getType() == Volume.Type.ROOT && > vmSpec.getPlatformEmulator().startsWith("Windows") && > ! vmSpec.getPlatformEmulator().equals("Windows PV")){ > ``` @skattoju4 @syed do you think the fix from @ustcweizhou will fix this? @kiwiflyer better configuration options for the os type sounds good.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
