rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/3333#discussion_r285968792
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##########
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
- libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
- // check router is up?
- final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+ if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+ break;
+ }
Review comment:
@ustcweizhou I can reduce that to 3 maybe.
I could consistently reproduce the issue with latest Ubuntu 19.10 with
latest Centos7.6 used as kvm host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
