DaanHoogland commented on a change in pull request #3350: Retrieve diagnostics
data rebase
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r287327487
##########
File path:
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
##########
@@ -54,6 +92,34 @@
private VirtualMachineManager vmManager;
@Inject
private NetworkOrchestrationService networkManager;
+ @Inject
+ private StatsCollector statsCollector;
+ @Inject
+ private DataStoreManager storeMgr;
+ @Inject
+ private BackgroundPollManager backgroundPollManager;
+ @Inject
+ private ImageStoreDetailsUtil imageStoreDetailsUtil;
+ @Inject
+ private NfsMountManager mountManager;
+ @Inject
+ private DataCenterDao dataCenterDao;
+
+ // This 2 settings should require a restart of the management server?
Review comment:
even though the comment here sugests otherwise all of these ```ConfigKey```s
are created as dynamic (last parameter in constructor is ```true```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
