svenvogel edited a comment on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-496039362 @ustcweizhou > @svenvogel sorryI did not say clearly. > I do not mind that cloud-install-sys-tmplt has no .sh as suffix, because it has been used for quite long time. Maybe some cloudstack users use the same command in their deployments. We'd better keep backward compatibility. > what I object is the rename or removal of the bash scripts Daan mentioned. There are two reasons (1) a bash script should have .sh as suffix, same as .py for python scripts. (2) The scripts might be used somewhere in code, or by some users. thats not consistent. either remove all .sh from files or add them to all files. this is consistent and logical. one should not argue differently on different places. i think with *.sh for all script or without it. backward compatibility is no argument at all. if this so no new product or change will come in the world. cloud-install-sys-tmplt is a bash script too! i cant agree. please choose one of them! I make the world as I like it is not a good deal i think. for me its done here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
