melnik13 commented on a change in pull request #3194: Suspending a VM before
snapshot deletion (see PR #3193)
URL: https://github.com/apache/cloudstack/pull/3194#discussion_r288887894
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -996,6 +996,12 @@ public Answer backupSnapshot(final CopyCommand cmd) {
primaryStore.getUuid());
if (state == DomainInfo.DomainState.VIR_DOMAIN_RUNNING &&
!primaryStorage.isExternalSnapshot()) {
final DomainSnapshot snap =
vm.snapshotLookupByName(snapshotName);
+ try {
+ vm.suspend();
Review comment:
Hello,
It's not required by the documentation, but many users encountered image
corruption, so it seems to be a good idea to suspend and resume the VM while
deleting a snapshot (Kevin Wolf from RedHat mentioned it too:
https://bugzilla.redhat.com/show_bug.cgi?id=920020#c5).
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
