rhtyd commented on a change in pull request #3371: Fix template size for
managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r289845382
##########
File path: scripts/storage/secondary/createtmplt.sh
##########
@@ -131,92 +123,66 @@ do
f) fflag=1
tmpltimg="$OPTARG"
;;
- s) sflag=1
- ;;
- d) dflag=1
- descr="$OPTARG"
- ;;
- S) Sflag=1
- size=$OPTARG
- let "size>>=10"
- ulimit -f $size
- ;;
- h) hflag=1
- hvm="true"
- ;;
- u) cleanup="true"
- ;;
- v) verbose="true"
- ;;
Review comment:
@svenvogel @DennisKonrad several flags/opts are removed from the script, do
you think it will cause regression in case the script is evoked via mgmt server
or ssvm agent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
