svenvogel edited a comment on issue #3371: Fix template size for managed 
storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-499383987
 
 
   @rhtyd @ustcweizhou i think i found the problem.
   
   ```java
   2019-06-05 10:39:22,031 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-18:null) (logid:) Seq 3-7430939385161318416: Processing:  
{ Ans: , MgmtId: 32987697710946, via: 3, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.storage.DownloadAnswer":{"jobId":"9a873f56-d3a0-4060-b17a-8d1dc333791c","downloadPct":100,"errorString":"Failed
 post download script: Usage: createtmplt.sh:\t-t templatefilesystem\t-n 
templatename\t-f 
templatefile","downloadStatus":"DOWNLOAD_ERROR","downloadPath":"/mnt/SecStorage/377b6981-ae30-3ab8-baad-24dc6bc37066/template/tmpl/2/202/dnld391260474745118648tmp_","installPath":"template/tmpl/2/202/4bd8d1fc-fbec-3115-8c15-a593820ded32.qcow2","templateSize":0,"templatePhySicalSize":0,"checkSum":"88c60fd500ce7ced985cf845df0db9da","result":true,"details":"Failed
 post download script: Usage: createtmplt.sh:\t-t templatefilesystem\t-n 
templatename\t-f templatefile","wait":0}}] }
   ```
   
   hey guys,
   
   maybe i found the problem. what you say @rhtyd its a lost flag.
   
https://github.com/apache/cloudstack/blob/d74b64c55b83d025be92a7b092660dbd3539538d/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java#L709-L710
   
   
https://github.com/apache/cloudstack/blob/d74b64c55b83d025be92a7b092660dbd3539538d/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java#L721-L728
   
   i think its the lost size flag. i can put them back but i have a question. 
in the first view it seems its not  in use an will not be calculated. in the 
second view it looks different and is in use. if its so i can remove the "//not 
used for now" comment and add the flag back to the createtmplt.sh. 
   ```java
   // not used for now
   ```
   if the calculation is not in use we could remove them but maybe anyone needs 
them in future? the size is not used in the createtmplt.sh file.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to