rafaelweingartner commented on a change in pull request #3389: when destroy the 
vms, delete the tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292208673
 
 

 ##########
 File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java
 ##########
 @@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int 
times, String macAddre
         Mockito.verify(networkModel, 
Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong());
         Assert.assertEquals(expectedMacAddress, returnedMacAddress);
     }
+
+    @Test
+    public void validateRemoveTagsWhenExists() {
 
 Review comment:
   You have test cases without any assert. How do you check if the method is 
doing what you want it to do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to