[GitHub] [cloudstack] NicoWohlfarth opened a new pull request #3395: Ui adaptations

Tue, 11 Jun 2019 02:31:42 -0700 

NicoWohlfarth opened a new pull request #3395: Ui adaptations
URL: https://github.com/apache/cloudstack/pull/3395
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   - Moved some recently made CSS changes 
(46a32795bcbefd7475d62421a71fbdeff0e2c407 / 
2020bfb6a3bf597d762e162a355ea3dfd26857eb) to their newly introduced respective 
SCSS files 
   - Aligned the dashboard containers properly (see screenshots 
[1](#screenshot1) and [2](#screenshot2))
   - Restored the original quick view tooltip background color (see screenshots 
[3](#screenshot3) and [4](#screenshot4))
   - Fixed the height of the toolbar in dialog views and also stretched it in 
width (see screenshots [5](#screenshot5) and [6](#screenshot6)
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots:
   
   1. <span name="screenshot1">Unaligned dashboard containers</span>
   
![Change_1_1](https://user-images.githubusercontent.com/12999459/59258667-ae30c600-8c38-11e9-91e9-ae16db6b94c4.png)
   2. <span name="screenshot2">Aligned dashboard containers</span>
   
![Change_1_2](https://user-images.githubusercontent.com/12999459/59258925-226b6980-8c39-11e9-8668-b89ffd69706f.png)
   3. <span name="screenshot3">Old quick view tooltip</span>
   
![Change_2_1](https://user-images.githubusercontent.com/12999459/59258994-3f07a180-8c39-11e9-8e6e-38c5cd524feb.png)
   4. <span name="screenshot4">New quick view tooltip</span>
   
![Change_2_2](https://user-images.githubusercontent.com/12999459/59259007-43cc5580-8c39-11e9-81e1-3ec8f2db9637.png)
   5. <span name="screenshot5">Old dialog view toolbar</span>
   
![Change_3_1](https://user-images.githubusercontent.com/12999459/59259058-5e063380-8c39-11e9-867f-c62c181d22df.png)
   6. <span name="screenshot6">New dialog view toolbar</span>
   
![Change_3_2](https://user-images.githubusercontent.com/12999459/59259079-65c5d800-8c39-11e9-9518-faecd6ea8300.png)
   
   ## How Has This Been Tested?
   Deployed to local environment and tested functionality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to