DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE]
server: return usage description with resource names and UUIDs
URL: https://github.com/apache/cloudstack/pull/3344#discussion_r295759813
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
##########
@@ -145,6 +150,9 @@ public void setUsageId(String usageId) {
this.usageId = usageId;
}
+ public boolean getOldFormat() {
+ return oldFormat != null && oldFormat;
Review comment:
I agree that this default is sensible and I don't think the backwards
incompatibility of not using internal ids anymore is going to be very hurtful
as the processing of such ids is more intensive than processing uuids using the
api. maybe a point of discussion for some, so let's be extra cautious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
