[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

[GitBox]

ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks 
and VIRTIO for data disks when platform emulator strings start with Windows* 
except Windows PV
URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509353969
 
 
   @rhtyd I am still -1 on this PR.
   
   @skattoju4 @svenvogel 
   Does the issue happen other OSes than Windows ? 
   I have tested os types windows/windows pv/other linux/ubuntu , all seem ok 
(the data disk is virtio), vms are running on NFS. So I think it is an issue 
with the disk definition in kvm plugin.
   
   look at the following lines in LibvirtComputingResource.java
   for NFS, the DATADISK has different disk bus type (diskBusTypeData = 
VIRTIO/SCSI) than ROOT disk (diskBusType = IDE/ VIRTIO/SCSI)
   ```
                   } else if (pool.getType() == StoragePoolType.CLVM || 
physicalDisk.getFormat() == PhysicalDiskFormat.RAW) {
                       disk.defBlockBasedDisk(physicalDisk.getPath(), devId, 
diskBusType);
                   } else {
                       if (volume.getType() == Volume.Type.DATADISK) {
                           disk.defFileBasedDisk(physicalDisk.getPath(), devId, 
diskBusTypeData, DiskDef.DiskFmtType.QCOW2);
                       } else {
                           disk.defFileBasedDisk(physicalDisk.getPath(), devId, 
diskBusType, DiskDef.DiskFmtType.QCOW2);
                       }
                   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services