anuragaw commented on a change in pull request #3501: Fix stop VM issue on
basic zones
URL: https://github.com/apache/cloudstack/pull/3501#discussion_r304730373
##########
File path:
server/src/main/java/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
##########
@@ -198,7 +198,7 @@ public boolean visit(final DhcpEntryRules dhcp) throws
ResourceUnavailableExcept
final DeployDestination destination = dhcp.getDestination();
final boolean remove = dhcp.isRemove();
- if (router.getPodIdToDeployIn().longValue() ==
destination.getPod().getId()) {
+ if (destination != null && router.getPodIdToDeployIn().longValue() ==
destination.getPod().getId()) {
Review comment:
Might as well be more defensive and add `router != null &&
router.getPodIdToDeployIn() != null`. In general being defensive is safer I
think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
