server24 commented on issue #3501: Fix stop VM issue on basic zones URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-512836856 > Did not test it @rhtyd @anuragaw @nvazquez This would avoid the command being executed at all, which is not the original intention. The destination is not necessary when removing something, as the DhcpRule in this case should already be deployed. So wouldn't it make more sense to change the if to: ``` if (router != null && (remove || (destination != null && destination.getPod() != null && router.getPodIdToDeployIn() != null && router.getPodIdToDeployIn().longValue() == destination.getPod().getId()))) { ``` I have recompiled with this test and the DHCP-entries are correct in the Basic Networking (create, start, stop, destroy, expunge VM tested).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
