server24 edited a comment on issue #3501: Fix stop VM issue on basic zones URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513335088 > IDK if this is expected but if you try to restart the network with clean up in a basic zone you get the > following exception: this is an issue that I had already reported the 3rd of January, 2019 to the developers list, relevant excerpt: ### ... a Network restart triggered using the UI fails with: "Can't find all necessary running routers!" I have looked up the source code for it and came to the following relevant snippet in server/src/main/java/com/cloud/network/element/VirtualRouterElement.java starting at line 234: ``` if (offering.isRedundantRouter() || network.isRollingRestart()) { expectedRouters = 2; } ``` From the log files I see that a rollingRestart is indeed triggered, but why does it expect two routers then? Because there might be two routers running simultaneously during the restart? If that was the case, then why in the following lines, relevant snippet (starting at line 237): ``` if (routers == null || routers.size() < expectedRouters) { //we might have a router which is already deployed and running. //so check the no of routers in network currently. List<DomainRouterVO> current_routers = _routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER); if (current_routers.size() < 2) { updateToFailedState(network); throw new ResourceUnavailableException("Can't find all necessary running routers!", DataCenter.class, network.getDataCenterId()); } } ``` is throwing an Exception when current_routers.size() is smaller than 2 and not smaller than 1? I understand that the logic is designed towards more complex networks, but will this logic not always fails for an already implemented BASIC network on KVM, with no redudant routers enabled and one VR already active? ... ### Back then nobody replied or gave feedback, glad that finally somebody is looking at this. Generally I have the feeling that no testing is ever done for Basic Networking... is everybody just using Advanced Networking with CS?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
