wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305921173
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
##########
@@ -397,15 +403,16 @@ private void deleteExistingLinkLocalRouteTable(String
linkLocalBr) {
}
final String device = tokens[2];
if (!Strings.isNullOrEmpty(device) &&
!device.equalsIgnoreCase(linkLocalBr)) {
- Script.runSimpleBashScript("ip route del " +
NetUtils.getLinkLocalCIDR() + " dev " + tokens[2]);
+ Script.runSimpleBashScript("ip route del " + _controlCidr
+ " dev " + tokens[2]);
} else {
foundLinkLocalBr = true;
}
}
}
+
if (!foundLinkLocalBr) {
- Script.runSimpleBashScript("ip address add 169.254.0.1/16 dev " +
linkLocalBr + ";" + "ip route add " + NetUtils.getLinkLocalCIDR() + " dev " +
linkLocalBr + " src " +
- NetUtils.getLinkLocalGateway());
+ Script.runSimpleBashScript("ip address add " +
NetUtils.getLinkLocalAddressFromCIDR(_controlCidr) + " dev " + linkLocalBr);
+ Script.runSimpleBashScript("ip route add " + _controlCidr + " dev
" + linkLocalBr + " src " +
NetUtils.getLinkLocalFirstAddressFromCIDR(_controlCidr));
Review comment:
Could be, but there aren't many methods calling it. I see what you mean, I
don't have a try preference for it though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
