rhtyd commented on a change in pull request #3534: [WIP] Misc fixes
URL: https://github.com/apache/cloudstack/pull/3534#discussion_r309135622
##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -92,7 +92,7 @@
static final ConfigKey<String> UserVMBlacklistedDetails = new
ConfigKey<String>("Advanced", String.class,
"user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
- "Determines whether users can view certain VM settings", true);
+ "Determines whether users can view certain VM settings. When set
to empty, default value used is: rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag.", true);
Review comment:
The main issue with setting to a fake value is that, what is the none is
used as a valid detail (most likely that's never going to happen but for
sanity-sake). Which is why I chose to simply state that behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
