rhtyd commented on a change in pull request #3648: Security Group: limit 
returns in get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#discussion_r337066374
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -149,7 +149,7 @@ def split_ips_by_family(ips):
 
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: 
vnet/ {print $2}'" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: 
vnet/ {print $2}' | head -1" % brname)
 
 Review comment:
   Can you rewrite this to use `iproute2` or a more modern tool?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to