andrijapanicsb opened a new pull request #3662: Increase lease time to infinite URL: https://github.com/apache/cloudstack/pull/3662 Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack. Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since (RHEL) system lose routes when they receive DHCPNAK. When VM is expunged, its active lease and DHCP/DNS config is properly removed (#3627 and #3608) from related files in VR, so the infinite duration of lease does not cause any issues or garbage. There will be soon a PR which also regenerates the /var/lib/misc/dnsmasq.leases (active lease DB file) in the new VR (when restarting network with cleanup), which will help around RHEL edge cases (described above) for the VMs who are already running in productions systems with 30d lease time. ## Description <!--- Describe your changes in detail --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
