DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM
ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r342603627
##########
File path:
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
##########
@@ -127,4 +129,24 @@ DiskProfile allocateTemplatedVolume(Type type, String
name, DiskOffering offerin
StoragePool findStoragePool(DiskProfile dskCh, DataCenter dc, Pod pod,
Long clusterId, Long hostId, VirtualMachine vm, Set<StoragePool> avoid);
void updateVolumeDiskChain(long volumeId, String path, String chainInfo);
+
+ /**
+ * Imports an existing volume for a VM into database. Useful while
ingesting an unmanaged VM.
+ * @param type Type of the volume - ROOT, DATADISK, etc
+ * @param name Name of the volume
+ * @param offering DiskOffering for the volume
+ * @param size DiskOffering for the volume
+ * @param minIops minimum IOPS for the disk, if not passed DiskOffering
value will be used
+ * @param maxIops maximum IOPS for the disk, if not passed DiskOffering
value will be used
+ * @param vm VirtualMachine this volume is attached to
+ * @param template Template of the VM of the volume
Review comment:
touching on functional requirements, which i do not want to, but how do we
know this disk actually adheres to any template known already. Is there a
prerequisites check somewhere, than please mention it here in the javadoc or
method below.
Is the template maybe created on the fly from the imported VM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
