DaanHoogland commented on a change in pull request #3635: server: acquire IPv4
address when add secondary IP to nic if IP is not specified
URL: https://github.com/apache/cloudstack/pull/3635#discussion_r348509156
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -732,11 +732,10 @@ public NicSecondaryIp allocateSecondaryGuestIP(final
long nicId, IpAddresses req
}
try {
- if (ipv4Address != null) {
- ipaddr = _ipAddrMgr.allocatePublicIpForGuestNic(network,
podId, ipOwner, ipv4Address);
- }
if (ipv6Address != null) {
ip6addr =
ipv6AddrMgr.allocatePublicIp6ForGuestNic(network, podId, ipOwner, ipv6Address);
+ } else {
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
