rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better 
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r348931489
 
 

 ##########
 File path: 
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java
 ##########
 @@ -47,11 +47,6 @@
  */
 public interface ResourceManager extends ResourceService, Configurable {
 
-    ConfigKey<Integer> HostMaintenanceRetries = new ConfigKey<>("Advanced", 
Integer.class,
 
 Review comment:
   Saw MaxRetries usage later in the code, in this case if we're 
deprecating/removing this ConfigKey, please add an upgrade path to delete the 
configuration from cloud.configuration as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to