ustcweizhou opened a new pull request #3701: security_group.py: check cidr unstrictly to accept cidrs like 1.1.1.1/24 URL: https://github.com/apache/cloudstack/pull/3701 ## Description <!--- Describe your changes in detail --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> When I add a security group rule with cidr like 1.1.1.1/24, the rule is not applied on kvm hypervisor. Ths issue does not exist in 4.13.0.0 and previous versions. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> It has been tested in advanced zone with security group. It can be verified very easily in python3, see results below. ``` # python3 Python 3.6.7 (default, Oct 22 2018, 11:32:17) [GCC 8.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import ipaddress >>> ipaddress.ip_network("1.1.1.1/28") IPv4Network('1.1.1.1/28') >>> ipaddress.ip_network("1.1.1.1/24") Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.6/ipaddress.py", line 74, in ip_network return IPv4Network(address, strict) File "/usr/lib/python3.6/ipaddress.py", line 1519, in __init__ raise ValueError('%s has host bits set' % self) ValueError: 1.1.1.1/24 has host bits set >>> ipaddress.ip_network("1.1.1.1/24", False) IPv4Network('1.1.1.0/24') ``` <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
