cl-k-takahashi opened a new issue #3705: ecdsa and ed25519 support for sshkeys URL: https://github.com/apache/cloudstack/issues/3705 <!-- Verify first that your issue/request is not already reported on GitHub. Also test if the latest release and master branch are affected too. Always add information AFTER of these HTML comments, but no need to delete the comments. --> ##### ISSUE TYPE <!-- Pick one below and delete the rest --> * Improvement Request ##### COMPONENT NAME <!-- Categorize the issue, e.g. API, VR, VPN, UI, etc. --> ~~~ API ~~~ ##### CLOUDSTACK VERSION <!-- New line separated list of affected versions, commit ID for issues on master branch. --> ~~~ master ~~~ ##### OS / ENVIRONMENT <!-- Information about the environment if relevant, N/A otherwise --> OS independent ##### SUMMARY <!-- Explain the problem/feature briefly --> According to `getPublicKeyFromKeyMaterial()@SSHKeysHelper.java`, CloudStack only supports rsa and dss ssh public keys. It is better to accept ecdsa and ed25519. ~~~ public static String getPublicKeyFromKeyMaterial(String keyMaterial) { if (!keyMaterial.contains(" ")) keyMaterial = new String(Base64.decodeBase64(keyMaterial.getBytes())); if ((!keyMaterial.startsWith("ssh-rsa") && !keyMaterial.startsWith("ssh-dss")) || !keyMaterial.contains(" ")) return null; String[] key = keyMaterial.split(" "); if (key.length < 2) return null; return key[0].concat(" ").concat(key[1]); } ~~~ ##### STEPS TO REPRODUCE <!-- For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate. For new features, show how the feature would be used. --> Registering ed25519 ssh public key to CloudStack fails. <!-- You can also paste gist.github.com links for larger files --> ##### EXPECTED RESULTS <!-- What did you expect to happen when running the steps above? --> Succeeding registering ecdsa or ed25519 public keys.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
