nvazquez commented on a change in pull request #3575: [WIP DO NOT MERGE] Health
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r350199545
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/router/ListRoutersCmd.java
##########
@@ -132,6 +136,11 @@ public String getRole() {
return Role.VIRTUAL_ROUTER.toString();
}
+ public boolean shouldIncludeHealthCheckResults() {
+ return includeHealthCheckResults == null ? false :
includeHealthCheckResults.booleanValue();
Review comment:
This can be simplified to BooleanUtils.isTrue(includeHealthCheckResults)
from the apache lang package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
