DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN
support on L2 networks
URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358123594
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1239,14 +1244,24 @@ public Network createGuestNetwork(CreateNetworkCmd
cmd) throws InsufficientCapac
}
}
- if (isolatedPvlan != null && (zone.getNetworkType() !=
NetworkType.Advanced || ntwkOff.getGuestType() != Network.GuestType.Shared)) {
- throw new InvalidParameterValueException("Can only support create
Private VLAN network with advance shared network!");
+ if (isNotBlank(isolatedPvlan) && (zone.getNetworkType() !=
NetworkType.Advanced || ntwkOff.getGuestType() == GuestType.Isolated)) {
+ throw new InvalidParameterValueException("Can only support create
Private VLAN network with advance shared or L2 network!");
Review comment:
typo: advance instead of advanced (not new)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
