DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358152728
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java
##########
@@ -45,6 +45,17 @@
static final String SetServiceMonitorCK =
"network.router.EnableServiceMonitoring";
static final String RouterAlertsCheckIntervalCK =
"router.alerts.check.interval";
+ static final String RouterHealthChecksEnabledCK =
"router.health.checks.enabled";
+ static final String RouterHealthChecksBasicIntervalCK =
"router.health.checks.basic.interval";
+ static final String RouterHealthChecksAdvancedIntervalCK =
"router.health.checks.advanced.interval";
+ static final String RouterHealthChecksDataRefreshIntervalCK =
"router.health.checks.data.refresh.interval";
+ static final String RouterHealthChecksResultFetchIntervalCK =
"router.health.checks.results.fetch.interval";
+ static final String RouterHealthChecksFailuresToRestartVrCK =
"router.health.checks.failures.to.restart.vr";
+ static final String RouterHealthChecksToExcludeCK =
"router.health.checks.to.exclude";
+ static final String RouterHealthChecksFreeDiskSpaceThresholdCK =
"router.health.checks.free.disk.space.threshold";
+ static final String RouterHealthChecksMaxCpuUsageThresholdCK =
"router.health.checks.max.cpu.usage.threshold";
+ static final String RouterHealthChecksMaxMemoryUsageThresholdCK =
"router.health.checks.max.memory.usage.threshold";
+
Review comment:
It is admittedly a matter of taste, but these are one time use plastics. I'd
rather see these in the ConfigKey<>s than here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
