DaanHoogland commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568753445 @shwstppr code looks good, but the bug existed IMHO because of the method being 200 lines long and thus illegible. I will let this pass to honour history but if you have time please factor out the method contents to a helper class or a set of helper methods? Also, i think we want this on 4.13. can you give a second look? tnx.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
