DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE]
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364173501
##########
File path:
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDaoImpl.java
##########
@@ -54,9 +57,12 @@ protected NetworkOfferingJoinDaoImpl() {
}
@Override
- public List<NetworkOfferingJoinVO> findByZoneId(long zoneId) {
+ public List<NetworkOfferingJoinVO> findByZoneId(long zoneId, Boolean
includeAllZoneOffering) {
SearchBuilder<NetworkOfferingJoinVO> sb = createSearchBuilder();
sb.and("zoneId", sb.entity().getZoneId(),
SearchCriteria.Op.FIND_IN_SET);
+ if (includeAllZoneOffering) {
+ sb.or("zId", sb.entity().getZoneId(), SearchCriteria.Op.NULL);
+ }
Review comment:
the idea is zId in set or null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
