weizhouapache commented on a change in pull request #3425: Better tracking host
maintanence and handling of migration jobs
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r366554730
##########
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##########
@@ -101,9 +103,14 @@
* ha.retry.wait | time to wait before retrying the work item |
seconds | 120 || || stop.retry.wait | time to wait
* before retrying the stop | seconds | 120 || * }
**/
-public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener {
+public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener, Configurable {
protected static final Logger s_logger =
Logger.getLogger(HighAvailabilityManagerImpl.class);
+ private ConfigKey<Integer> MaxRetries = new ConfigKey<>("Advanced",
Integer.class,
+ "max.retries","5",
Review comment:
@anuragaw @rhtyd
sorry I have some late comments as this PR has been merged.
1) max.retries is not used in the past so I suggest to rename it before 4.14
release.
2) this config has scope=Cluster but cluster-wide configuration is never
used in code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
