nvazquez commented on a change in pull request #3743: only update powerstate if
sure it is the latest
URL: https://github.com/apache/cloudstack/pull/3743#discussion_r366846281
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java
##########
@@ -130,23 +136,34 @@ private void processReport(long hostId, Map<Long,
VirtualMachine.PowerState> tra
}
}
- if (s_logger.isDebugEnabled())
- s_logger.debug("Detected missing VM. host: " + hostId + ",
vm id: " + instance.getId() +
- ", power state: PowerReportMissing, last state
update: " + vmStateUpdateTime.getTime());
+ if (s_logger.isInfoEnabled()) {
+ s_logger.info(
+ String.format("Detected missing VM. host: %l, vm
id: %l(%s), power state: %s, last state update: %l"
Review comment:
Hi @DaanHoogland, I'm getting this error in latest master:
````
INFO [c.c.a.m.AgentManagerImpl] (AgentTaskPool-98:ctx-ad691272)
(logid:1a451217) The agent from host 1 state determined is Up
INFO [c.c.a.m.AgentManagerImpl] (AgentTaskPool-98:ctx-ad691272)
(logid:1a451217) Agent is determined to be up and running
WARN [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-8:null) (logid:)
Caught:
java.util.UnknownFormatConversionException: Conversion = 'l'
at java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2691)
at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2720)
at java.util.Formatter.parse(Formatter.java:2560)
at java.util.Formatter.format(Formatter.java:2501)
at java.util.Formatter.format(Formatter.java:2455)
at java.lang.String.format(String.java:2940)
at
com.cloud.vm.VirtualMachinePowerStateSyncImpl.processReport(VirtualMachinePowerStateSyncImpl.java:141)
at
com.cloud.vm.VirtualMachinePowerStateSyncImpl.processHostVmStatePingReport(VirtualMachinePowerStateSyncImpl.java:66)
at
com.cloud.vm.VirtualMachineManagerImpl.processCommands(VirtualMachineManagerImpl.java:3245)
at
com.cloud.agent.manager.AgentManagerImpl.handleCommands(AgentManagerImpl.java:309)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(AgentManagerImpl.java:1287)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManagerImpl.java:1370)
at
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.doTask(ClusteredAgentManagerImpl.java:702)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
