DaanHoogland commented on issue #3383: template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-575184813
 
 
   @andrijapanicsb I have an implementation for this which is somewhat of a 
discussion point; the problem was/is that if you download an archived template 
(i.e. bz2 or so) the checksum you give will be that of the archive and not of 
the template therein. On download complete the checksum is checked (if given) 
and if not it is generated and added to the template.
   I have changed the code so that the added checksum is the generated from the 
template and not from the archive, which makes a little more sense as that is 
what we are going to copy around later on. However in the old case, whether you 
gave a checksum or not, and in the new case only if you give a checksum, that 
will be entered in the db and upon registration completely useless. if such an 
archive-checksum exists any copy will fail. If it doesn't or if the template 
wasn't an archive to begin with, the cross copy zone will succeed.
   
   what do you think,
   cc @rhtyd @PaulAngus @borisstoyanov @othersoranybody

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to