DaanHoogland commented on a change in pull request #3748: [WIP DO NOT MERGE]
Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r371843874
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
##########
@@ -276,7 +276,7 @@ public EndPoint select(DataObject object) {
}
if (object instanceof TemplateInfo) {
TemplateInfo tmplInfo = (TemplateInfo)object;
- if (store.getScope().getScopeType() == ScopeType.ZONE &&
store.getScope().getScopeId() == null && tmplInfo.getTemplateType() ==
TemplateType.SYSTEM) {
+ if (store.getScope().getScopeType() == ScopeType.ZONE &&
store.getScope().getScopeId() == null || tmplInfo.getTemplateType() ==
TemplateType.SYSTEM) {
Review comment:
`store.getScope().getScopeType() == ScopeType.ZONE &&
store.getScope().getScopeId() == null` is always false, is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
