bwsw opened a new pull request #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839 ## Description <!--- Describe your changes in detail --> The PR introduces the new KVM agent extension interface in the form of hooks. Every hook is implemented in Groovy like ``` package groovy class BaseTransform { String transform(Object logger, String xml) { File file = new File("/tmp/hooks.txt") file.append("------------------------------------------------------------------------\n") file.append(xml) return xml } } new BaseTransform() ``` There are 3 hooks are implemented now: 1. `XML transformer` which is called right before VM is launched and it allows modifying XML somehow (example above) 2. `onStart` and `onStop` hooks which are called right after VM state changes to started/stopped. ``` package groovy class StateHandler { Object onStart(Object logger, String vmName) { File file = new File("/tmp/hooks-start.txt") file.append(vmName) return null } Object onStop(Object logger, String vmName) { File file = new File("/tmp/hooks-stop.txt") file.append(vmName) return null } } new StateHandler() ``` Every hook is run inside `try {} catch (Exception e) {}`, so it can not cause agent misbehavior. If hooks are not defined, they are skipped. Also, the PR adds initial support for GitLab CICD for those, who does WIPs with GitLab, not in GitHub. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> Initial RFC/Proposal: https://github.com/apache/cloudstack/issues/3823 <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Tested in unit tests and manually for master. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
