bwsw edited a comment on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-585549981 @DaanHoogland @rhtyd @nvazquez Hi, the XML functionality is similar but differs very much. Read that discussion: https://github.com/apache/cloudstack/issues/3823 It may look similar in the way it acts, but completely different from the perspective of the ISP operation, especially for public cloud. This PR allows extending CS at a scale beyond the CS functionality implemented in the system. Your PR allows users adding the options to XML. E.g. In your PR there is no way to select *any* of the available NVME drives installed in the platform during VM deployment and attach it to the VM using some advanced logic. * My PR is for public cloud operators, who percept CS as a constructor; * Your PR is for private cloud operators who percept CS as a final system. The PR is ready to be merged from my point of view. I suppose It's better to merge it to avoid diff accumulation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
