DaanHoogland commented on a change in pull request #3794: [WIP] create Volume
Access Groups per cluster instead of CloudStack-RandomUUID()
URL: https://github.com/apache/cloudstack/pull/3794#discussion_r372341084
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -692,39 +699,63 @@ public static void
placeVolumeInVolumeAccessGroups(SolidFireConnection sfConnect
throw new CloudRuntimeException(errMsg);
}
+ // Get list of VAGs from solidfire
List<SolidFireUtil.SolidFireVag> sfVags =
SolidFireUtil.getAllVags(sfConnection);
- Map<SolidFireUtil.SolidFireVag, List<String>> sfVagToIqnsMap = new
HashMap<>();
+ // Populate vag to iqn(host) map
Review comment:
great name of method call below makes this comment obsolete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
