onitake commented on issue #3575: Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-579900919 @andrijapanicsb Well, building a custom ISO is not exactly convenient either. But in most cases, the added preparation step and a build job on our CI would be worth it. If you have to change checks often, this will be very inconvenient, however. Pushing changes to VRs directly is something we want to avoid, as this can lead to strange problems if something is missed. We did something like that in the past. But, paired with updating the image, it might be a feasible option. On the other hand, adding an API to inject custom scripts into VRs is (obviously) a big security risk. In any case, any input to health check execution _must_ be properly sanitized to avoid injection attacks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
