DaanHoogland commented on a change in pull request #3383: template: copy md5
mismatch
URL: https://github.com/apache/cloudstack/pull/3383#discussion_r372863119
##########
File path:
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
##########
@@ -1052,6 +1052,9 @@ public void syncTemplateToRegionStore(long templateId,
DataStore store) {
DataObject templateOnStore = destStore.create(tmplForCopy);
templateOnStore.processEvent(Event.CreateOnlyRequested);
+ // I am the big assumer^Wpretender
Review comment:
I changed the code but the net effect stays the same. If it isn't a
`TemplateObject` an exception is thrown and should be thrown. we'll be in the
wrong spot in that case.
@rhtyd ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
