skattoju4 commented on a change in pull request #3794: [WIP] create Volume
Access Groups per cluster instead of CloudStack-RandomUUID()
URL: https://github.com/apache/cloudstack/pull/3794#discussion_r374164919
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -683,19 +694,58 @@ private static SolidFireVag
getVagForRandomHostInCluster(List<SolidFireUtil.Soli
return null;
}
- public static void placeVolumeInVolumeAccessGroups(SolidFireConnection
sfConnection, long sfVolumeId, List<HostVO> hosts) {
+ public static void placeVolumeInVolumeAccessGroups(SolidFireConnection
sfConnection, long sfVolumeId, List<HostVO> hosts, String clusterUuId) {
Review comment:
we need the list of hosts to build the vag to iqn map, we need the hostDao
to get the list of hosts. I think it is better to just pass the list of hosts
in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
