DaanHoogland commented on a change in pull request #3553: CloudStack Backup &
Recovery Framework
URL: https://github.com/apache/cloudstack/pull/3553#discussion_r377505235
##########
File path:
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
##########
@@ -174,7 +174,7 @@ public boolean removeVMFromBackupOffering(final
VirtualMachine vm) {
if (!client.removeVMFromVeeamJob(vm.getBackupExternalId(),
vm.getInstanceName(), vmwareDC.getVcenterHost())) {
LOG.warn("Failed to remove VM from Veeam Job id: " +
vm.getBackupExternalId());
}
- } catch (CloudRuntimeException e) {
+ } catch (Exception e) {
LOG.debug("VM was removed from the job so could not remove again,
trying to delete the veeam job now.", e);
Review comment:
can't we catch a veeam specific exception? anything may pass as this now
(mem/npe/io/...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
