ravening opened a new pull request #3904: Avoid duplicate alerts when router 
state changes
URL: https://github.com/apache/cloudstack/pull/3904
 
 
   ## Description
   <!--- Describe your changes in detail -->
   When both router of VPC are in MASTER state
   then multiple alerts are sent equal to the number of tiers in the VPC.
   If the VPC has 3 tiers then 6 alerts will be sent. This is not good
   if VPC has more than 10 networks in it.
   
   Instead of checking the router status for all the tiers in the VPC,
   just check the status of rotuer for one tier in a VPC so that
   multiple deplicate alerts can be avoided
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   Alerts Dashboard when both routers are in MASTER state in VPC
   
   ![Screenshot 2020-02-20 at 15 00 
20](https://user-images.githubusercontent.com/10645273/74940840-59159880-53f2-11ea-8eb1-fbb66c8df7e3.png)
   
   
   
   After the fix, when both routers are in master state
   
   
   ![Screenshot 2020-02-20 at 15 09 
16](https://user-images.githubusercontent.com/10645273/74941249-01c3f800-53f3-11ea-90ba-c9052de89443.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   1 . Create a VPC with redundant VR's and multiple tiers in it
   2. Change the state of the BACKUP VR to MASTER.
   3 . You will see multiple alerts in the Cloudstack dashboard
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to