GabrielBrascher commented on a change in pull request #3903: VR: Send VM 
password to all Running VRs in network/vpc
URL: https://github.com/apache/cloudstack/pull/3903#discussion_r382205814
 
 

 ##########
 File path: 
server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
 ##########
 @@ -702,18 +702,27 @@ public boolean savePassword(final Network network, final 
NicProfile nic, final V
 
         // If any router is running then send save password command otherwise
         // save the password in DB
+        boolean savePasswordResult = true;
+        boolean isVrRunning = false;
 
 Review comment:
   @ravening can you please make both variables private?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to