shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable
Direct Download for System VMs
URL: https://github.com/apache/cloudstack/pull/3731#discussion_r382901352
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -1835,6 +1838,9 @@ public Boolean doInTransaction(final TransactionStatus
status) {
_vlanDao.remove(vlan.getId());
}
+ // delete template refs for this zone
+ templateZoneDao.deleteByZoneId(zoneId);
Review comment:
@DaanHoogland please review if this is the correct place to cleanup
template_zone_ref entries for a zone to be removed? Or should this call be made
after the successful removal of DataCenterVO in success block below?
cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
