weizhouapache commented on issue #3899: vpc: add bypassvlanoverlapcheck parameter when create private gateway URL: https://github.com/apache/cloudstack/pull/3899#issuecomment-589992713 > this is a lot of code change for a little functional change, what I've seen so far looks good, but I do want to take an hour or so later to go through it line by line. If others test extensively that fina as well, by me. > (@rhtyd @weizhouapache @andrijapanicsb) @DaanHoogland there are actually two main changes which are not independent. (1) add vpcid in method getPrivateNetwork. (2) add bypassvlanoverlapcheck parameter when create private gateway in test_privategw_acl.py, it tests the vm connectivity between two VPCs. The two VPCs connect each time by private gateways. The two private gateways have same cidr/vlan, but different gateway (gateway of private gateway in a VPC is the ip attached on another VPC). in method getPrivateNetwork, the private gateways with same cidr/vlan are mapped to the same isolated network, so one of them has wrong gateway. That's why many trillian test failed. Therefore I add vpcid to method getPrivateNetwork so they are mapped to different network (with correct gateway). It has another issue that they use same vlan, so I have to add bypassvlanoverlapcheck parameter.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
