rhtyd commented on a change in pull request #3681: Validate disk offering IOPS
normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681#discussion_r386863471
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -400,6 +400,20 @@
public static final ConfigKey<Boolean> SystemVMUseLocalStorage = new
ConfigKey<Boolean>(Boolean.class, "system.vm.use.local.storage", "Advanced",
"false",
"Indicates whether to use local storage pools or shared storage
pools for system VMs.", false, ConfigKey.Scope.Zone, null);
+ public final static ConfigKey<Long> BYTES_MAX_READ_LENGTH= new
ConfigKey<Long>(Long.class, "vm.disk.bytes.maximum.read.length", "Advanced",
"0",
Review comment:
I'm not sure how to test/review this. Should this be checked by the storage
driver or hypervisor plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
