DaanHoogland commented on a change in pull request #3927: ui: fix merge issue
that causes VR duplicates
URL: https://github.com/apache/cloudstack/pull/3927#discussion_r387512908
##########
File path: ui/scripts/system.js
##########
@@ -9996,7 +9996,7 @@
}
$.ajax({
- url:
createURL("listRouters&listAll=true&page=" + args.page + "&pagesize=" +
pageSize + array1.join("") + "&projectid=-1"),
+ url:
createURL("listRouters&page=" + args.page + "&pagesize=" + pageSize +
array1.join("") + "&projectid=-1"),
Review comment:
```
listall | If set to false, list only resources belonging to the command's
caller; if set to true - list resources that the caller is authorized to see.
Default value is false
```
so if the admin calls this and a router would not belong to them... I'll
test some scenarios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
