rhtyd commented on a change in pull request #3638: UEFI Support on CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r392571666
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -148,6 +149,15 @@ public String reserveVirtualMachine(VMEntityVO
vmEntityVO, DeploymentPlanner pla
VMInstanceVO vm = _vmDao.findByUuid(vmEntityVO.getUuid());
VirtualMachineProfileImpl vmProfile = new
VirtualMachineProfileImpl(vm);
vmProfile.setServiceOffering(_serviceOfferingDao.findByIdIncludingRemoved(vm.getId(),
vm.getServiceOfferingId()));
+ if (MapUtils.isNotEmpty(vmEntityVO.getDetails()) &&
+
vmEntityVO.getDetails().containsKey(VirtualMachineProfile.Param.UefiFlag.getName())
&&
+
"yes".equalsIgnoreCase(vmEntityVO.getDetails().get(VirtualMachineProfile.Param.UefiFlag.getName())))
Review comment:
@pavanaravapalli
Can you make this simpler - just put in the key in the details only when
it's applicable, then you don't need to compare the uefi value at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
