Spaceman1984 commented on issue #3949: Fix CloudRuntimeException of migrated volume for Volume stats URL: https://github.com/apache/cloudstack/pull/3949#issuecomment-599420687 I have tested #3884 with the code from this PR, I still get the null pointer while migrating a volume and stats run. I wasn't able to reproduce the error in the description after migrating storage. These are the steps I followed: - Change volume.stats.interval global setting to 10000 - Create an instance - Stop the instance - Migrate the volume to a different primary storage - Check the management server log for the error. Results: No runtime exception The next step I followed was: - Delete the file from primary storage Result: I have verified the error in management server logs: `2020-03-13 16:54:51,585 DEBUG [c.c.a.m.AgentManagerImpl] (StatsCollector-6:ctx-96e6db97) (logid:24749a89) Details from executing class com.cloud.agent.api.GetVolumeStatsCommand: Can't get vm disk stats: Can't find volume:76071844-5bab-42cc-a656-9c47cf0b7797` Seems like this PR improves logging of the error when a volume is missing from the storage pool, not when a volume was migrated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
