kioie commented on issue #3997: [WIP] New API endpoint: UpdateVlanIpRange
URL: https://github.com/apache/cloudstack/pull/3997#issuecomment-605612658
 
 
   > @kioie you don't have to resubmit
   > you can use commands like `git rebase` and `git push --force` to clear out 
mess that might have grown in your PRs. I now lost where your code was 
discussed before. (no biggy we'll find it, but a slight inconvenience)
   > 
   > That said, I remember a discussion about ensuring overlap and validating 
all IPs are still contained. Can you add a brief description on how you 
addressed that here, please. I'll get to reviewing the code again soon.
   > Thanks
   > 
   > @rhtyd can you review as well?
   
   Sorry about this, I'm having issues on my end with git force push, but I'll 
get to the bottom of it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to