DaanHoogland commented on a change in pull request #4003: Logging framework to
use only log4j and wrapper slf4j
URL: https://github.com/apache/cloudstack/pull/4003#discussion_r402939700
##########
File path:
utils/src/main/java/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java
##########
@@ -44,7 +41,7 @@
public class ConstantTimeBackoff extends AdapterBase implements
BackoffAlgorithm, ConstantTimeBackoffMBean {
long _time;
private final Map<String, Thread> _asleep = new ConcurrentHashMap<String,
Thread>();
- private final static Log LOG =
LogFactory.getLog(ConstantTimeBackoff.class);
+ private static final Logger s_logger =
Logger.getLogger(ConstantTimeBackoff.class.getName());
Review comment:
no, please, the s_ is an old convention. LOGGER is ok, but LOG as well. I
prefer the latter, but as long as we standardise on something I'm fine with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
