pavanaravapalli commented on a change in pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089#discussion_r426720512
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2286,12 +2286,22 @@ protected StartAnswer execute(StartCommand cmd) {
}
if (StringUtils.isNotBlank(bootMode) &&
!bootMode.equalsIgnoreCase("bios")) {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("booting %s in %s mode and
type %s",
+ vmInternalCSName,
+ bootMode,
+
vmSpec.getDetails().containsKey(ApiConstants.BootType.UEFI.toString()) ?
vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString()) : "<nada>"));
+ }
vmConfigSpec.setFirmware("efi");
if
(vmSpec.getDetails().containsKey(ApiConstants.BootType.UEFI.toString()) &&
"secure".equalsIgnoreCase(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString())))
{
VirtualMachineBootOptions bootOptions = new
VirtualMachineBootOptions();
bootOptions.setEfiSecureBootEnabled(true);
vmConfigSpec.setBootOptions(bootOptions);
}
+ else
Review comment:
@DaanHoogland I have not tested but code LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
